[Yoga] Minimize number of nodes that have MeasureFunc set on them. #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has one important benefit: fixing the stretching behavior of spacer nodes. In addition, it should help efficiency of Yoga and certainly minimize calls to layoutThatFits:. Next up for Yoga is a mostly-red diff, deleting the non-Contiguous code branches.
appleguy
force-pushed
the
YogaMeasureFunc
branch
from
b5c6be0
to
c5b0402
Compare
maicki
approved these changes
Jun 18, 2017
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…extureGroup#369) This has one important benefit: fixing the stretching behavior of spacer nodes. In addition, it should help efficiency of Yoga and certainly minimize calls to layoutThatFits:. Next up for Yoga is a mostly-red diff, deleting the non-Contiguous code branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Yoga support is still highly experimental and is not
planned to become a supported / documented mode of the framework.
We recommend that most apps use ASStackLayoutSpec and the other
specs: http://texturegroup.org/docs/layout2-layoutspec-types.html
This has one important benefit: fixing the stretching behavior of spacer nodes. In addition, it should help efficiency of Yoga and certainly minimize calls to layoutThatFits:.
In the Yoga layout mode of ASDKgram, note how the timestamp is now correctly at the right-hand side of the screen, as allowed by a flexible spacer node placed in the photo header's horizontal stack: