Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gate orphaned node detector behind YOGA flag #trivial #380

Merged
merged 2 commits into from
Jun 22, 2017
Merged

Gate orphaned node detector behind YOGA flag #trivial #380

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb3ff1a
Gate orphaned node detector behind YOGA flag
nguyenhuy Jun 22, 2017
2723c85
Tiny indentation change
nguyenhuy Jun 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Source/ASDisplayNode+Layout.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ - (NSString *)asciiArtName
{
NSString *string = NSStringFromClass([self class]);
if (_debugName) {
string = [string stringByAppendingString:[NSString stringWithFormat:@"\"%@\"",_debugName]];
string = [string stringByAppendingString:[NSString stringWithFormat:@"\"%@\"", _debugName]];
}
return string;
}
Expand Down Expand Up @@ -864,7 +864,11 @@ - (void)_assertSubnodeState

- (void)_pendingLayoutTransitionDidComplete
{
// This assertion introduces a breaking behavior for nodes that has ASM enabled but also manually manage some subnodes.
// Let's gate it behind YOGA flag and remove it right after a branch cut.
#if YOGA
[self _assertSubnodeState];
#endif

// Subclass hook
[self calculatedLayoutDidChange];
Expand Down