Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASDisplayNode+Layout] In layoutThatFits:, check and use _pending layout if valid. #413

Merged
merged 2 commits into from
Jul 5, 2017
Merged

[ASDisplayNode+Layout] In layoutThatFits:, check and use _pending layout if valid. #413

merged 2 commits into from
Jul 5, 2017

Commits on Jul 4, 2017

  1. [ASDisplayNode+Layout] In layoutThatFits:, check and use _pending lay… 

    …out if valid.

I believe this check is supposed to be here. Unit tests pass with it in place.
Without it, calling layoutThatFits: (as ASDataController does) and then calling
it again later (as ASCollectionNode does when answering the sizeForItem: call)
will recompute the layout, potentially on main.

This seems to have more of an impact / benefit for Yoga layouts, but I don't think
its benefit is exclusive to them.
    @appleguy
    appleguy committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    1b62406 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into PendingLayout

    @appleguy
    appleguy committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    088c7d8 View commit details
    Browse the repository at this point in the history