Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASDataController] Fix a crash in table view caused by executing an empty change set during layoutSubviews #416

Merged
merged 2 commits into from
Jul 5, 2017
Merged

[ASDataController] Fix a crash in table view caused by executing an empty change set during layoutSubviews #416

merged 2 commits into from
Jul 5, 2017

Commits on Jul 4, 2017

  1. Fix a crash in table view caused by executing an empty change set dur… 

    …ing layoutSubviews

- Previously, when a change set is empty, `ASDataController` forwards the change set to its delegate right away, without dispatching to its editing queue and then back to main.
- This behaviour can potentially cause bad internal states in UITableView which trigger a crash reported in TextureGroup#83.
- Fix by still reusing the existing pending map, because the data source's state has not changed, but go through the editing queue and main queue tunnel.
    @nguyenhuy
    nguyenhuy committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    35adc49 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG

    @nguyenhuy
    nguyenhuy committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    4da9659 View commit details
    Browse the repository at this point in the history