[ASDataController] Apply new visible map inside batch updates block #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚫 CI failed with log |
|
🚫 CI failed with log |
nguyenhuy
force-pushed
the
HNScrollingWhileBatchUpdatesCrash
branch
from
63e11a5
to
3e66173
Compare
nguyenhuy
force-pushed
the
HNScrollingWhileBatchUpdatesCrash
branch
from
3e66173
to
735946f
Compare
|
Alright, merging. Thanks guys! |
nguyenhuy
added a commit
to nguyenhuy/Texture
that referenced
this pull request
Jul 14, 2017
…hods into one - After TextureGroup#420, there is no change occurs between those 2 methods. Having them separately doesn't achieve anything and can cause confusions.
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…extureGroup#420) * ASDataController to apply new visible map inside batch updates block * Update CHANGELOG * Sorry, put up a PR that doesn't even build LOL
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…angeSet delegate methods #trivial (TextureGroup#445) * Merge willUpdateWithChangeSet and didUpdateWithChangeSet delegate methods into one - After TextureGroup#420, there is no change occurs between those 2 methods. Having them separately doesn't achieve anything and can cause confusions. * Minor change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #378. Tested with the project attached in that report and smoke tested ASDKgram.