[ASDisplayNode] Fix some gaps in the bridging of new contents* properties. #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ties. I audited this more carefully and found some gaps in my PR from yesterday. This also ensures the grouping and ordering of all the contents properties is consistent across all of the places they appear. In the future, it would be great to make the #define macros more sophisticated so that we can add property bridging with fewer lines changed, and for objects besides ASDisplayNode too!
Generated by 🚫 Danger |
maicki
approved these changes
Jul 12, 2017
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…ties. (TextureGroup#435) I audited this more carefully and found some gaps in my PR from yesterday. This also ensures the grouping and ordering of all the contents properties is consistent across all of the places they appear. In the future, it would be great to make the #define macros more sophisticated so that we can add property bridging with fewer lines changed, and for objects besides ASDisplayNode too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I audited this more carefully and found some gaps in my PR from yesterday.
This also ensures the grouping and ordering of all the contents properties
is consistent across all of the places they appear.
In the future, it would be great to make the #define macros more sophisticated
so that we can add property bridging with fewer lines changed, and for
objects besides ASDisplayNode too!