[ASDataController] Clean up #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhuy
force-pushed
the
HNCleanUpDataController
branch
from
fa8e4c1
to
da65f60
Compare
- Parameters passed to ASDataControllerCompletionBlock are no longer used. Remove them. - The value returned by _allocateNodesFromElements:andLayout:completion is not used. Remove it. - Elements are not allocated and measured in batches anymore. Remove the code that does batch allocation. - Remove RETURN_IF_NO_DATASOURCE. It's used only once and is not worth it.
nguyenhuy
force-pushed
the
HNCleanUpDataController
branch
from
237d5a6
to
276ed3c
Compare
|
Thanks, @maicki! |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Clean up ASDataController - Parameters passed to ASDataControllerCompletionBlock are no longer used. Remove them. - The value returned by _allocateNodesFromElements:andLayout:completion is not used. Remove it. - Elements are not allocated and measured in batches anymore. Remove the code that does batch allocation. - Remove RETURN_IF_NO_DATASOURCE. It's used only once and is not worth it. * Remove +parallelProcessorCount * Update CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-_allocateNodesFromElements:andLayout:completionis not used. Remove it.+parallelProcessorCount.RETURN_IF_NO_DATASOURCEmacro. It's used only once and is not worth it.