Fix issue with swipe to delete cell gesture. #trivial #46
Conversation
|
|
|
@rewcraig can you rebase this please to fix the build failure? (sorry CI should have posted it, looking into why it didn't) |
rewcraig
force-pushed
the
swipetodelete
branch
2 times, most recently
from
810da7b
to
5c8a28e
Compare
rewcraig
changed the title
|
🚫 CI failed with log |
|
🚫 CI failed with log |
|
@rewcraig I don't think this failure is your fault, I've put up a fix and will let you know when it's in master. Thanks for sticking with us :) |
|
Fix landed in master if you don't mind rebasing. |
|
No trouble at all. |
Source/ASTableView.mm
Outdated
| superResponds = [UITableView instancesRespondToSelector:_cmd]; \ | ||
| }); \ | ||
| return superResponds; \ | ||
| }() |
There was a problem hiding this comment.
Nice! Rather than specifying this as a block, let's just make it a scope:
#define UITABLEVIEW_RESPONDS_TO_SELECTOR() \
({ \
static BOOL superResponds; \
static dispatch_once_t onceToken; \
dispatch_once(&onceToken, ^{ \
superResponds = [UITableView instancesRespondToSelector:_cmd]; \
}); \
superResponds; \
})
Ensure superclass scroll view delegate methods are called when the scroll view parameter is not the current ASTableView.
|
I knew there must be some way to build that macro without a block. Much better! |
|
@rewcraig This would be needed for ASCollectionView too right? |
|
I have not tried this with ASCollectionView. However, from what I can tell UICollectionView does not implement any of the UIScrollViewDelegate methods. Are you seeing evidence to suggest ASCollectionView suffers from a similar issue? I'd be happy to help in any way. |
Ensure superclass scroll view delegate methods are called when the scroll view parameter is not the current ASTableView.
Fixes #38