[ASNodeController] Add -nodeDidLayout callback. Allow switching retain behavior at runtime. #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n behavior at runtime. With these changes, I'd also like to propose that we move ASNodeController out of Beta (renaming the files without +Beta). Let me know what you think! Because we don't support ASNodeController directly in ASCV / ASTV, it is still important to allow flipping the ownership in certain cases (in particular, for root CellNodeController objects that should follow the lifecycle of the ASCellNode rather than owning the ASCellNode).
Adlai-Holler
approved these changes
Jul 24, 2017
| { | ||
| // Associated objects don't support weak references. Since assign can become a dangling pointer, use ASWeakProxy. | ||
| ASWeakProxy *nodeControllerProxy = [ASWeakProxy weakProxyWithTarget:nodeController]; | ||
| objc_setAssociatedObject(self, @selector(__nodeController), nodeControllerProxy, OBJC_ASSOCIATION_RETAIN_NONATOMIC); |
There was a problem hiding this comment.
I'm cool with this, but why not add 2 @package ivars to ASDisplayNode and use those instead?
|
@Adlai-Holler - @Package sounds great, but what header could it be in? I'd rather not keep adding so much rob ASDIsplayNodeInternal, but maybe it's acceptable to do so. |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…n behavior at runtime. (TextureGroup#470) With these changes, I'd also like to propose that we move ASNodeController out of Beta (renaming the files without +Beta). Let me know what you think! Because we don't support ASNodeController directly in ASCV / ASTV, it is still important to allow flipping the ownership in certain cases (in particular, for root CellNodeController objects that should follow the lifecycle of the ASCellNode rather than owning the ASCellNode).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, I'd also like to propose that we move ASNodeController
out of Beta (renaming the files without +Beta). Let me know what you think!
Because we don't support ASNodeController directly in ASCV / ASTV, it is still
important to allow flipping the ownership in certain cases (in particular, for
root CellNodeController objects that should follow the lifecycle of the
ASCellNode rather than owning the ASCellNode).