Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subclassing.md #479

Merged
merged 2 commits into from
Jul 28, 2017
Merged

Update subclassing.md #479

merged 2 commits into from
Jul 28, 2017

Conversation

oferRounds
Copy link
Contributor

Adding the fact that didLoad is called only once.

P.s. I‘m not an English native speaker, so there might be a better phrasing.

Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for the diff! Let's lower-case the "i": method; it’s called once.

Lowered-case the "i".
@oferRounds
Copy link
Contributor Author

Done!

Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Adlai-Holler Adlai-Holler merged commit c2f6b90 into TextureGroup:master Jul 28, 2017
@oferRounds
Copy link
Contributor Author

Sure :)

bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
* Update subclassing.md

* Update subclassing.md

Lowered-case the "i".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants