Update corner-rounding.md #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I understand right, both Precomposited corners techniques uses `[path clip]`, right? If so, I think it will be better to move it to the general description of the section, as currently it seems as only the second option uses `[path clip]`.
|
Perhaps in the future, it’s also worth adding some concrete code examples, and maybe also make this section a bit more general — to include other actions which trigger offscreen rendering, such as using the |
Improved positioning.
Syntax consistency: Changed `off-screen` to `offscreen`, as both syntaxes currently appears in the text.
|
@appleguy - and just a question I was wondering about — why is iOS built in this way that when using the I.e., If Apple would like to change this behaviour, can they do things different in the way that the clipping operation would not trigger the offscreen rendering, or is this thing is inherently unavoidable? |
|
@oferRounds Thanks for doing this! :) |
appleguy
approved these changes
Aug 20, 2017
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Update corner-rounding.md If I understand right, both Precomposited corners techniques uses `[path clip]`, right? If so, I think it will be better to move it to the general description of the section, as currently it seems as only the second option uses `[path clip]`. * Update corner-rounding.md Improved positioning. * Update corner-rounding.md Syntax consistency: Changed `off-screen` to `offscreen`, as both syntaxes currently appears in the text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understand right, both Precomposited Corners techniques uses
[path clip].If so, I think it will be better to move it to the general description of the section, as currently it seems as if only the second technique uses
[path clip].