Update adoption-guide-2-0-beta1.md #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the “number” looks like a mistake - Changed `"` to `“` to match the ending sign
garrettmoon
reviewed
Jul 28, 2017
| @@ -122,7 +122,7 @@ Other updates include: | |||
|
|
|||
| - Renamed `pagerNode:constrainedSizeForNodeAtIndexPath:` to `pagerNode:constrainedSizeForNodeAtIndex:` | |||
|
|
|||
| - collection view update validation assertions are now enabled. If you see something like `"Invalid number of items in section 2. The number of items after the update (7) must be equal to the number of items before the update (4) plus or minus the number of items inserted or removed from the section (4 inserted, 0 removed)”`, please check the data source logic. If you have any questions, reach out to us on GitHub. | |||
| - collection view update validation assertions are now enabled. If you see something like `“Invalid number of items in section 2. The number of items after the update (7) must be equal to the number of items before the update (4) plus or minus the number of items inserted or removed from the section (4 inserted, 0 removed)”`, please check the data source logic. If you have any questions, reach out to us on GitHub. | |||
There was a problem hiding this comment.
Do you actually mind making both of them non-smart quotes?
Changing both sign to non-smart
|
@garrettmoon sure, done. |
garrettmoon
approved these changes
Jul 28, 2017
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Update adoption-guide-2-0-beta1.md - Removed the “number” looks like a mistake - Changed `"` to `“` to match the ending sign * Update adoption-guide-2-0-beta1.md Changing both sign to non-smart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"to“to match the ending sign in: