Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASCollectionLayout improvements #513

Merged
merged 1 commit into from
Aug 17, 2017
Merged

ASCollectionLayout improvements #513

merged 1 commit into from
Aug 17, 2017

Conversation

nguyenhuy
Copy link
Member

  • During the first layout calculation, measure more than just elements in the visible viewport.
  • Remove unncessary params in -[ASCollectionLayoutState getAndRemoveUnmeasuredLayoutAttributesPageTableInRect].

@nguyenhuy nguyenhuy force-pushed the HNCollectionLayoutMoreElements branch 2 times, most recently from 72bdb2c to d595aa0 Compare August 15, 2017 21:36
Adlai-Holler
Adlai-Holler approved these changes Aug 15, 2017
View reviewed changes
Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification! And it makes sense – UICV uses a page-based system like we do so it'll often query us for more than just the visible rect. 👍

@nguyenhuy nguyenhuy force-pushed the HNCollectionLayoutMoreElements branch from d595aa0 to 2c9a73c Compare August 17, 2017 13:45
@nguyenhuy
ASCollectionLayout improvements
1f6488a 
- During the first layout calculation, measure more than just elements in the visible viewport.
- Remove unnecessary params in `-[ASCollectionLayoutState getAndRemoveUnmeasuredLayoutAttributesPageTableInRect`.]
@nguyenhuy nguyenhuy force-pushed the HNCollectionLayoutMoreElements branch from 2c9a73c to 1f6488a Compare August 17, 2017 13:46
@nguyenhuy nguyenhuy merged commit 5e13eba into TextureGroup:master Aug 17, 2017
@nguyenhuy nguyenhuy deleted the HNCollectionLayoutMoreElements branch August 17, 2017 14:31
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
@nguyenhuy @bernieperez
ASCollectionLayout improvements (TextureGroup#513)
f395199 
- During the first layout calculation, measure more than just elements in the visible viewport.
- Remove unnecessary params in `-[ASCollectionLayoutState getAndRemoveUnmeasuredLayoutAttributesPageTableInRect`.]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adlai-Holler Adlai-Holler Adlai-Holler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nguyenhuy @Adlai-Holler