Make ASWeakMapEntry Value Atomic #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhuy
approved these changes
Sep 7, 2017
Source/Private/ASWeakMap.m
Outdated
| @@ -19,6 +19,7 @@ | |||
|
|
|||
| @interface ASWeakMapEntry () | |||
| @property (nonatomic, strong) NSObject *key; | |||
There was a problem hiding this comment.
May worth making key read-only.
|
I went a little overboard and also changed the |
nguyenhuy
approved these changes
Sep 7, 2017
CHANGELOG.md
Outdated
| @@ -16,6 +16,7 @@ | |||
| - Table and collection views to consider content inset when calculating (default) element size range [Huy Nguyen](https://github.com/nguyenhuy) [#525](https://github.com/TextureGroup/Texture/pull/525) | |||
| - [ASEditableTextNode] added -editableTextNodeShouldBeginEditing to ASEditableTextNodeDelegate to mirror the corresponding method from UITextViewDelegate. [Yan S.](https://github.com/yans) [#535](https://github.com/TextureGroup/Texture/pull/535) | |||
| - [Breaking] Remove APIs that have been deprecated since 2.0 and/or for at least 6 months [Huy Nguyen](https://github.com/nguyenhuy) [#529](https://github.com/TextureGroup/Texture/pull/529) | |||
| - Fixed a memory corruption issue in the ASImageNode display system. [Adlai Holler](https://github.com/Adlai-Holler) [#55](https://github.com/TextureGroup/Texture/pull/555) | |||
maicki
approved these changes
Sep 8, 2017
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Make ASWeakMapEntry value atomic * Increment changelog * Go a little nuts * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing a variety of memory corruption crashes around the image values in the ASImageNode display pipeline.
It could be unrelated, but there exists a race on the
valueproperty of ASWeakMapEntry which is implementednonatomicbut is read/written from different threads.