Fixes a potential deadlock; it's not safe to message likely super nod… #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettmoon
force-pushed
the
fixPotentialDeadlock
branch
from
4833258
to
a236df8
Compare
nguyenhuy
reviewed
Apr 21, 2017
|
@nguyenhuy That's a better idea, will update. |
|
@nguyenhuy hmmm, that actually increases the complexity of the code quite a bit. I need to keep 2 extra arrays around because responder could potentially be nil (so I can't use the original |
|
@garrettmoon Can we have a single array of |
garrettmoon
force-pushed
the
fixPotentialDeadlock
branch
from
a236df8
to
9fb1896
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…es while holding the lock.