[ASCollectionLayout] Exclude content inset on scrollable directions from viewport size #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚫 CI failed with log |
…from viewport size
nguyenhuy
force-pushed
the
HNViewportSizeExcludingContentInset
branch
from
7df699b
to
25f5076
Compare
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…from viewport size (TextureGroup#562)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing to do this will cause
ASCollectionLayoutto report a content size that spans beyond the safe scrollable area of the collection node. In case ofASPagerNode, that then causes the pager to bounce vertically and messes up with the pull-to-dismiss gesture in closeup.