[_ASPendingState] Make sure accessibility strings are not nil before allocating attributed strings for them #trivial #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nguyenhuy
commented
Sep 25, 2017
nguyenhuy
commented
- Fix crashes caused by Added attributed versions of accessibilityLabel, accessibilityHint, accessibilityValue #554
|
🚫 CI failed with log |
|
🚫 CI failed with log |
nguyenhuy
commented
Sep 25, 2017
Tests/ASDisplayNodeTests.mm
Outdated
| @@ -353,7 +353,7 @@ - (void)checkValuesMatchDefaults:(ASDisplayNode *)node isLayerBacked:(BOOL)isLay | |||
| XCTAssertEqual((id)nil, node.accessibilityLabel, @"default accessibilityLabel is broken %@", hasLoadedView); | |||
| XCTAssertEqual((id)nil, node.accessibilityHint, @"default accessibilityHint is broken %@", hasLoadedView); | |||
| XCTAssertEqual((id)nil, node.accessibilityValue, @"default accessibilityValue is broken %@", hasLoadedView); | |||
| if (AS_AT_LEAST_IOS11) { | |||
| if (@available(iOS 11.0, *)) { | |||
There was a problem hiding this comment.
Switching to @available to make CI happy.
There was a problem hiding this comment.
We're assuming everyone is using Xcode 9 now I guess?
There was a problem hiding this comment.
No, this is only for CI and contributors. Users aren't forced into Xcode 9.
|
🚫 CI failed with log |
|
🚫 CI failed with log |
maicki
approved these changes
Sep 25, 2017
Tests/ASDisplayNodeTests.mm
Outdated
| @@ -353,7 +353,7 @@ - (void)checkValuesMatchDefaults:(ASDisplayNode *)node isLayerBacked:(BOOL)isLay | |||
| XCTAssertEqual((id)nil, node.accessibilityLabel, @"default accessibilityLabel is broken %@", hasLoadedView); | |||
| XCTAssertEqual((id)nil, node.accessibilityHint, @"default accessibilityHint is broken %@", hasLoadedView); | |||
| XCTAssertEqual((id)nil, node.accessibilityValue, @"default accessibilityValue is broken %@", hasLoadedView); | |||
| if (AS_AT_LEAST_IOS11) { | |||
| if (@available(iOS 11.0, *)) { | |||
There was a problem hiding this comment.
We're assuming everyone is using Xcode 9 now I guess?
nguyenhuy
force-pushed
the
HNNilLabels
branch
from
9c085e8
to
0192449
Compare
|
🚫 CI failed with log |
…ted strings for them - Fix crashes caused by TextureGroup#554
nguyenhuy
force-pushed
the
HNNilLabels
branch
from
0192449
to
55fe868
Compare
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…allocating attributed strings for them #trivial (TextureGroup#581) * Make sure accessibility strings are not nil before allocating attributed strings for them - Fix crashes caused by TextureGroup#554 * Update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.