Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move clearing out of ASTextKitComponents property delegates into ASTextKitComponents dealloc #trivial #591

Merged
merged 1 commit into from
Sep 30, 2017

Conversation

maicki
Copy link
Contributor

@maicki maicki commented Sep 27, 2017

No description provided.

@maicki maicki requested review from Adlai-Holler and removed request for Adlai-Holler September 27, 2017 17:59
@maicki maicki force-pushed the MSMoveTextKitComponentsPropertyDelegateClearing branch from c8c4dfe to df07dde Compare September 29, 2017 15:27
@maicki maicki force-pushed the MSMoveTextKitComponentsPropertyDelegateClearing branch from df07dde to 4f52a3c Compare September 29, 2017 15:31
Copy link
Member

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghost
Copy link

ghost commented Sep 29, 2017

🚫 CI failed with log

@maicki maicki merged commit 5c6cd7c into master Sep 30, 2017
@maicki maicki deleted the MSMoveTextKitComponentsPropertyDelegateClearing branch October 1, 2017 14:55
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants