[ASCollectionView] Call -invalidateFlowLayoutDelegateMetrics when rotating. #trivial #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…led for UIKit passthrough cells. This allows rotation to work properly when rotating UIKit passthrough cells that need to change width.
appleguy
changed the title
Adlai-Holler
approved these changes
Oct 23, 2017
| BOOL fixedHorizontally = (ASScrollDirectionContainsHorizontalDirection(scrollDirection) == NO); | ||
|
|
||
| BOOL changedInNonScrollingDirection = (fixedHorizontally && newBounds.size.width != lastUsedSize.width) || (fixedVertically && newBounds.size.height != lastUsedSize.height); | ||
| BOOL changedInNonScrollingDirection = (fixedHorizontally && newSize.width != lastUsedSize.width) || | ||
| (fixedVertically && newSize.height != lastUsedSize.height); |
There was a problem hiding this comment.
:-D thanks for sharing your aesthetic approval, always good to see & re-align as a team
nguyenhuy
requested changes
Oct 24, 2017
Source/ASCollectionView.mm
Outdated
| @@ -367,6 +367,7 @@ - (void)scrollToItemAtIndexPath:(NSIndexPath *)indexPath atScrollPosition:(UICol | |||
|
|
|||
| - (void)relayoutItems | |||
| { | |||
| [self invalidateFlowLayoutDelegateMetrics]; | |||
|
@nguyenhuy @Adlai-Holler thanks guys - ready for another look |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…ating. #trivial (TextureGroup#616) * [ASCollectionView] Ensure -invalidateFlowLayoutDelegateMetrics is called for UIKit passthrough cells. This allows rotation to work properly when rotating UIKit passthrough cells that need to change width. * [ASCollectionView] No need to verify node is still in model to handle view-only notifications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows rotation to work properly when rotating UIKit passthrough
cells that need to change width.
This diff was written and tested for use with #431, but it's fundamentally the same with the current HEAD.