[Tests] Add test scrollToPageAtIndex ASPagerNode #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remirobert
changed the title
nguyenhuy
approved these changes
Oct 24, 2017
nguyenhuy
requested changes
Oct 24, 2017
Tests/ASPagerNodeTests.m
Outdated
| @@ -90,6 +90,14 @@ - (void)testPagerReturnsNotFoundForCellThatDontExistInPager { | |||
| XCTAssertEqual([testController.pagerNode indexOfPageWithNode:badNode], NSNotFound); | |||
| } | |||
|
|
|||
| - (void)testScrollPageToIndex { | |||
There was a problem hiding this comment.
Per our project convention, please put the bracket on a new line.
While on it, please also update other methods to follow the same rule.
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* add scrollToPageAtIndex for the ASPagerNode * update convention code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny PR to add test scrollToPageAtIndex for the ASPagerNode