Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASScrollNode] Fix small bugs and add unit tests #637

Merged
merged 11 commits into from
Dec 1, 2017
Merged

[ASScrollNode] Fix small bugs and add unit tests #637

merged 11 commits into from
Dec 1, 2017

Commits on Dec 1, 2017

  1. Add unit tests for ASScrollNode

    @nguyenhuy
    nguyenhuy committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    f0a3940 View commit details
    Browse the repository at this point in the history

  2. Make sure ASScrollNode's size is clamped against its size range

    @nguyenhuy
    nguyenhuy committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    6bc3f91 View commit details
    Browse the repository at this point in the history

  3. Invalidate ASScrollNode's calculated layout if its scrollable directi… 

    …ons changed
    @nguyenhuy
    nguyenhuy committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    6768044 View commit details
    Browse the repository at this point in the history

  4. Update comment

    @nguyenhuy
    nguyenhuy committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    52db036 View commit details
    Browse the repository at this point in the history

  5. Update CHANGELOG

    @nguyenhuy
    nguyenhuy committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    8731cca View commit details
    Browse the repository at this point in the history

  6. Address Adlai's comments

    @nguyenhuy
    nguyenhuy committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    8d190f7 View commit details
    Browse the repository at this point in the history

  7. More clean-ups

    @nguyenhuy
    nguyenhuy committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    5c20dd6 View commit details
    Browse the repository at this point in the history

  8. Minor changes

    @nguyenhuy
    nguyenhuy committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    3fcae88 View commit details
    Browse the repository at this point in the history

  9. Minor changes

    @nguyenhuy
    nguyenhuy committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    8d33fd4 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into HNTestScrollNode

    @nguyenhuy
    nguyenhuy committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    74da33c View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into HNTestScrollNode

    @nguyenhuy
    nguyenhuy committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    67549f8 View commit details
    Browse the repository at this point in the history