[ASCollectionView] Prevent prefetching from being enabled to eliminate overhead. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e overhead. Some apps explicitly enable this, which is counterproductive with ASDK.
Generated by 🚫 Danger |
|
@Adlai-Holler @nguyenhuy Did we not recently have a conversation about this, as we discovered some problem around it? What was the conclusion again? Otherwise looks good to me! |
|
@maicki The conclusion is that we want to disable prefetching universally and rely on our built-in ranges. Prior to facebookarchive/AsyncDisplayKit#3263, |
nguyenhuy
approved these changes
Apr 24, 2017
maicki
approved these changes
Apr 24, 2017
|
Awesome, thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some apps explicitly enable this, which is counterproductive with ASDK. This can also worsen data inconsistency issues as it creates additional traffic from UIKit.