Make it possible to map between sections even if they're empty #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
commented
Nov 3, 2017
| @@ -64,8 +64,6 @@ | |||
| return __val; \ | |||
| } | |||
|
|
|||
| #define ASIndexPathForSection(section) [NSIndexPath indexPathForItem:0 inSection:section] | |||
There was a problem hiding this comment.
Removed this macro because using item 0 is only something that's done for flow layout headers and footers. In any other context, "index path for section" would mean a one-node index path.
appleguy
approved these changes
Nov 3, 2017
There was a problem hiding this comment.
This is a really big step forward for apps to seamlessly work across the view <-> model spaces. Thank you @Adlai-Holler; the change looks correct and I'll start testing it in detail.
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…reGroup#660) * Make section mapping work even for empty sections * Unlock more cases and update changelog * Fix complexity documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was no native way to map between sections. So our best shot was to pick item 0 and translate its index path, and then read the section index. This has a couple of failure modes:
To fix this and provide more direct section tracking, we:
ASSectionobjects, even if the data source provides no context for them.In the future I hope we can go further with
ASSectionbut this is a good start.