The ASDKgram example doesn't compile. #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
maicki
approved these changes
Dec 6, 2017
nguyenhuy
requested changes
Dec 8, 2017
| @@ -428,7 +428,7 @@ | |||
| GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; | |||
| GCC_WARN_UNUSED_FUNCTION = YES; | |||
| GCC_WARN_UNUSED_VARIABLE = YES; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 8.0; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 9.0; | |||
There was a problem hiding this comment.
The changes in this file are unintentional I guess?
There was a problem hiding this comment.
This was intentional. It doesn't compile otherwise.
|
OK, I've changed the spacing to tabs. |
nguyenhuy
reviewed
Dec 19, 2017
| @@ -428,7 +428,7 @@ | |||
| GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; | |||
| GCC_WARN_UNUSED_FUNCTION = YES; | |||
| GCC_WARN_UNUSED_VARIABLE = YES; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 8.0; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 9.0; | |||
| completion(.failure(error)) | ||
| } | ||
| }.resume() | ||
| DispatchQueue.main.async { |
There was a problem hiding this comment.
The indentation seems to be 1 tab too far?
| completion(.failure(error)) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Shouldn't we call resume() here?
There was a problem hiding this comment.
Indeed! Changed and retested.
…et to get the project compiling.
nguyenhuy
approved these changes
Dec 19, 2017
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
- Fix an insta-crash that's caused by Webservice.load method to call its completion block off the main thread. - Fix incorrect http status code check. - Bump the deployment target to get the project compiling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also crashes right away because it expects the Webservice.load method to return on the main thread.
I fixed these issues and an error whereby all valid responses return as failed.