Ensure an ASM enabled node applies its pending layout when enters preload state #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…load state This makes sure subnodes are inserted and start preloading right away, instead of waiting until the next layout pass of the supernode. Fixes TextureGroup#693.
nguyenhuy
force-pushed
the
HNASMAndInterfaceState
branch
from
33943c5
to
e5ca7f6
Compare
nguyenhuy
requested review from
maicki,
garrettmoon,
appleguy and
Adlai-Holler
maicki
approved these changes
Dec 7, 2017
nguyenhuy
commented
Dec 7, 2017
| @@ -2,8 +2,6 @@ | |||
| // ASDisplayNodeImplicitHierarchyTests.m | |||
| // Texture | |||
| // | |||
| // Created by Levi McCallum on 2/1/16. | |||
There was a problem hiding this comment.
Sorry Levi, Danger forces me to do this :)
appleguy
reviewed
Dec 8, 2017
| // (see __layout and _u_measureNodeWithBoundsIfNecessary:). | ||
| // This scenario should be uncommon, and running a measurement pass here is a fine trade-off because preloading | ||
| // any time after this point would be late. | ||
| [self layoutIfNeeded]; |
There was a problem hiding this comment.
Does this work in the case of a node that doesn't have self.isNodeLoaded yet?
Ideally, we would be able to flush the layout / ASM process without relying on a CoreAnimation call at all. For example, a codepath that could call __layout without relying on -layoutSubviews.
There was a problem hiding this comment.
nguyenhuy
added a commit
that referenced
this pull request
Jan 17, 2018
…rs preload state (#751) - After #706, a layout pass is forced on an ASM-enabled node that enters preload state to make sure that its subnodes can start preloading as well. However, when the node is visible, a (coalesced, thus more efficient) layout pass will be triggered by CA soon anyways, so rely on it instead.
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…load state (TextureGroup#706) This makes sure subnodes are inserted and start preloading right away, instead of waiting until the next layout pass of the supernode. Fixes TextureGroup#693.
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…rs preload state (TextureGroup#751) - After TextureGroup#706, a layout pass is forced on an ASM-enabled node that enters preload state to make sure that its subnodes can start preloading as well. However, when the node is visible, a (coalesced, thus more efficient) layout pass will be triggered by CA soon anyways, so rely on it instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure subnodes are inserted and start preloading right away, instead of waiting until the next layout pass of the supernode. Fixes #693.