[ASCollectionElement] Check for nil elements on ASTableView as well. #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
reviewed
Dec 11, 2017
Generated by 🚫 Danger |
|
Thank you very much @maicki. Any news on this? |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This protects
ASTableView'swillDisplayCell:forRowAtIndexPath:anddidEndDisplayingCell:forRowAtIndexPath:against nil elements, matching the behaviour added toASCollectionViewon #421. Should fix the crash reported in #709.I also added
consumesCellNodeVisibilityEventsto_ASTableViewCell, again to resemble the implementation of its counterpart_ASCollectionViewCell.Any feedback is very much welcome.