Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASPrimitiveTraitCollection] Always treat preferredContentSize as a potential nil #trivial #757

Merged
merged 3 commits into from
Mar 21, 2018
Merged

[ASPrimitiveTraitCollection] Always treat preferredContentSize as a potential nil #trivial #757

merged 3 commits into from
Mar 21, 2018

Commits on Jan 19, 2018

  1. Fix ASPrimitiveTraitCollection initialization on iOS 9. 

    Add nil-value checks for preferredContentSizeCategory.
    @ypogribnyi
    ypogribnyi committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    8ebd277 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2018

  1. * Mark -[ASTraitCollection init] as deprecated. 

    * Mark [ASViewController overrideDisplayTraitsWithWindowSize] as deprecated.

Code review changes:
* Remove unneeded nonnull annotations
* Add null check in ASTraitCollection constructor implementation
* Codestyle
* Add some documentation about ASPrimitiveTraitCollection vs ASTraitCollection usage
    @ypogribnyi
    ypogribnyi committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    549adb5 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2018

  1. Rename safeContentSizeCategory to AS_safeContentSizeCategory. 

    Remove safePrimitiveContentSizeCategory in favour of AS_safeContentSizeCategory.
    @ypogribnyi
    ypogribnyi committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    88bb48e View commit details
    Browse the repository at this point in the history