Update PINCache #769
Merged
Update PINCache #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nguyenhuy
approved these changes
Jan 26, 2018
There was a problem hiding this comment.
Approving since we're doing the same for PINRemoteImage. Would love to have approval from another maintainer as well, maybe especially @garrettmoon?
Btw, thank you for the diff, @justinswart.
|
Sure thing, hope it helps someone else! |
Adlai-Holler
approved these changes
Jan 30, 2018
fumito-ito
added a commit
to fumito-ito/RxASDataSources
that referenced
this pull request
Apr 4, 2018
Older PINCache causes runtime erorr sometimes. To avoid this problem, set version of PINCache. refs: TextureGroup/Texture#769
dangthaison91
pushed a commit
to RxSwiftCommunity/RxASDataSources
that referenced
this pull request
Apr 24, 2018
* use newer PINCache to avoid runtime error Older PINCache causes runtime erorr sometimes. To avoid this problem, set version of PINCache. refs: TextureGroup/Texture#769 * use PINCache 3.0.1-beta.6 or later with submodule reference
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the issue described in pinterest/PINRemoteImage#363, I've been experiencing the runtime error
dyld: Symbol not found: _PINDiskCachePrefixwhen using Carthage and Texture in my project.The solution described in the referenced issue is to checkout
PINRemoteImageseparately, runcarthage updateand then copy the built frameworks over. This works and appears to be becausePINRemoteImagereferencesPINCacheat the3.0.1-beta.6release.I've updated Texture's
Cartfilein this PR to also referencePINCacheat3.0.1-beta.6. This does appear to solve the runtime error for my project so I'm suggesting this change for others that may experience this crash.