Expose asyncdisplaykit_node in _ASDisplayView same as in _ASDisplayLayer #trivial #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
commented
Jan 29, 2018
Source/Details/_ASDisplayView.h
Outdated
| @discussion This property overrides the CALayer category method which implements this via associated objects. | ||
| This should result in much better performance for _ASDisplayLayers. | ||
| */ | ||
| @property (nonatomic, weak) ASDisplayNode *asyncdisplaykit_node; |
There was a problem hiding this comment.
We may should add proper nullable annotations for this and in _ASDisplayLayer too as both could be nil.
maicki
changed the title
nguyenhuy
approved these changes
Jan 30, 2018
Adlai-Holler
pushed a commit
that referenced
this pull request
Jan 30, 2018
…yer #trivial (#773) * Expose asyncdisplaykit_node in _ASDisplayView same as in _ASDisplayLayer * Change comment
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…yer #trivial (TextureGroup#773) * Expose asyncdisplaykit_node in _ASDisplayView same as in _ASDisplayLayer * Change comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an upcoming diff I need to have access to the node of the
_ASDisplayView. To be aligned with_ASDisplayLayerwe should expose it the same way. We exposed it within https://github.com/facebookarchive/AsyncDisplayKit/pull/2346/files for_ASDisplayLayer