Improve nullable annotations for _ASDisplayLayer and _ASDisplayView #trivial #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhuy
reviewed
Jan 31, 2018
| @@ -28,7 +30,7 @@ | |||
| @discussion This property overrides the CALayer category method which implements this via associated objects. | |||
| This should result in much better performance for _ASDisplayLayers. | |||
| */ | |||
| @property (nonatomic, weak) ASDisplayNode *asyncdisplaykit_node; | |||
| @property (nullable, nonatomic, weak) ASDisplayNode *asyncdisplaykit_node; | |||
There was a problem hiding this comment.
Weak properties are nullable by default.
There was a problem hiding this comment.
I would rather go with the explicit case. You are right in theory the compiler is creating the exact same output, but if you look into Apple's header, e.g. UITableView.h weak properties like delegate or dataSource are still annotated with nullable.
nguyenhuy
approved these changes
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.