Add missing scrollViewWillEndDragging passthrough delegate #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
maicki
approved these changes
Feb 10, 2018
There was a problem hiding this comment.
LGTM. But let's have @Adlai-Holler the last call on this as he is knowing the most about our IGListKit integration.
|
This looks good to me; I am also about to submit a change to this file to extend its functionality :) |
appleguy
approved these changes
Feb 11, 2018
|
@xezero Can you please add an entry to the CHANGELOG.md. Thanks! |
|
@maicki Added! |
|
🚫 CI failed with log |
Adlai-Holler
approved these changes
Feb 12, 2018
There was a problem hiding this comment.
CI is failing for an unrelated error. This diff is simple enough that we can land. Thanks @xezero!
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…oup#796) * Add scrollViewWillEndDragging delegate * Make sure delegate can respond to scrollViewWillEndDragging * Add changes to CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no way to implement this useful scroll view delegate when using an IGListAdapter in conjunction with AsyncDisplayKit since it wasn't being passed through.