[ASDisplayNode] Fix an issue that causes a node to sometimes return an outdated calculated size or size range #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhuy
changed the title
…n outdated calculated size or size range
nguyenhuy
force-pushed
the
HNInvalidCalculatedSize
branch
from
eda7613
to
d509970
Compare
nguyenhuy
commented
Feb 24, 2018
| @@ -305,24 +305,22 @@ - (void)_u_measureNodeWithBoundsIfNecessary:(CGRect)bounds | |||
| } | |||
|
|
|||
| CGSize boundsSizeForLayout = ASCeilSizeValues(bounds.size); | |||
| NSUInteger calculatedVersion = _calculatedDisplayNodeLayout->version; | |||
There was a problem hiding this comment.
Note to reviewers: No change in the logic of this method (-_u_measureNodeWithBoundsIfNecessary:), just call the new isValid() function to (hopefully) increase readability.
nguyenhuy
force-pushed
the
HNInvalidCalculatedSize
branch
from
30b1c9d
to
a406cef
Compare
maicki
approved these changes
Feb 25, 2018
|
@nguyenhuy any updates on this? |
|
@nguyenhuy should we be moving forward on this? I'm considering (finally) pulling in the _layoutVersion changes, which I avoided for a while...wondering if this is an important fix before doing so. cc @maicki, @Adlai-Holler |
Adlai-Holler
approved these changes
May 21, 2018
|
Wooohoo 🙌 🎉 ! I depended heavily on this feature working. Thank you so much guys 😄 |
|
@Adlai-Holler Thanks for syncing with master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When asked for the calculated size or constrained size for the calculated layout, prefer the pending layout only if its version is up-to-date. This should fix the issue reported by @codeOfRobin (here) and reproducible by this sample project.