Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASTextNode] Fix locking, add test for issue #trivial #825

Merged
merged 5 commits into from
Mar 9, 2018
Merged

[ASTextNode] Fix locking, add test for issue #trivial #825

merged 5 commits into from
Mar 9, 2018

Conversation

Adlai-Holler
Copy link
Member

garrettmoon
garrettmoon approved these changes Mar 9, 2018
View reviewed changes
Copy link
Member

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Adlai-Holler Adlai-Holler merged commit 6f1d2d1 into master Mar 9, 2018
@Adlai-Holler Adlai-Holler deleted the AHTruncationTokenAttributePrecedence branch March 9, 2018 22:23
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
@Adlai-Holler @bernieperez
[ASTextNode] Fix locking, add test for issue #trivial (TextureGroup#825)
8efeb29 
* A few small fixes plus a failing test for ASTextNode

* Change the approach

* Update changelog

* Eh screw null_resettable

* No need for changelog now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maicki maicki maicki approved these changes

@garrettmoon garrettmoon garrettmoon approved these changes

Assignees
No one assigned
Labels
ASTextNode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Adlai-Holler @maicki @garrettmoon