Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order items in XCode project navigator by name #835

Merged

Conversation

OleksiyA
Copy link
Contributor

It is a bit hard to find file in folders with long list of file, for example Tests. Sorting items by name makes this a bit easier and brings order.
If there are child folders, they are ordered before files. Keeping folders sorted by name may be reasonable alternative as well.

It is a bit hard to find file in folders with long list of file, for example Tests. Sorting items by name makes this a bit easier and brings order.
If there are child folders, they are ordered before files. Keeping folders sorted by name may be reasonable alternative as well.
@CLAassistant
Copy link

CLAassistant commented Mar 13, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OleksiyA ! This looks good to me.

Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too! Thanks!

@nguyenhuy
Copy link
Member

@OleksiyA Could you please rebase with master and resolve conflicts? Thanks!

# Conflicts:
#	AsyncDisplayKit.xcodeproj/project.pbxproj
ASNetworkImageLoadInfo.h is still here, not sure why showing removed in this commit. Had this file duplicated  reference previously?
@OleksiyA
Copy link
Contributor Author

Merged master, updated this PR.

@Adlai-Holler Adlai-Holler merged commit 255aec5 into TextureGroup:master Mar 24, 2018
@Adlai-Holler
Copy link
Member

Thanks @OleksiyA , very clean and nice improvement.

@OleksiyA OleksiyA deleted the Order-Project-Items-by-Name branch March 26, 2018 18:18
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
* Order items in XCode project navigator by name

It is a bit hard to find file in folders with long list of file, for example Tests. Sorting items by name makes this a bit easier and brings order.
If there are child folders, they are ordered before files. Keeping folders sorted by name may be reasonable alternative as well.

* Re-sort after merge.

ASNetworkImageLoadInfo.h is still here, not sure why showing removed in this commit. Had this file duplicated  reference previously?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants