Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cache support animated image #850

Merged
merged 13 commits into from
Mar 25, 2018

Conversation

wsdwsd0829
Copy link
Contributor

ASImageContainerProtocol only take data for animated image (instead of UIImage).
This will match the usage as in:
https://github.com/TextureGroup/Texture/blob/master/Source/Details/ASPINRemoteImageDownloader.m#L193

Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice – great fix!

@Adlai-Holler
Copy link
Member

If you'll add an entry to the CHANGELOG we can merge this immediately.

@wsdwsd0829
Copy link
Contributor Author

Done, thanks for reviewing.

@Adlai-Holler Adlai-Holler merged commit 3d9fe8c into TextureGroup:master Mar 25, 2018
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
* fix SIMULATE_WEB_RESPONSE not imported TextureGroup#449

* Fix to make rangeMode update in right time

* support animated image for cache

* Modify change log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants