Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Hashing Code #86

Merged
merged 3 commits into from
Apr 29, 2017
Merged

Simplify Hashing Code #86

merged 3 commits into from
Apr 29, 2017

Conversation

Adlai-Holler
Copy link
Member

  • New function ASHashBytes copied from CFHashBytes
  • Replaces all other hashing code.
  • Much of the hashing code was unused.

nguyenhuy
nguyenhuy approved these changes Apr 29, 2017
View reviewed changes
Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

maicki
maicki approved these changes Apr 29, 2017
View reviewed changes
Copy link
Contributor

@maicki maicki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's actually how NSCache does hashing in their libcache callbacks. Looks good to me too.

@Adlai-Holler Adlai-Holler merged commit 456dc85 into master Apr 29, 2017
@Adlai-Holler Adlai-Holler deleted the AHSimplerHashing branch April 29, 2017 22:23
@CoderXL CoderXL mentioned this pull request Sep 28, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maicki maicki maicki approved these changes

@nguyenhuy nguyenhuy nguyenhuy approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Adlai-Holler @maicki @nguyenhuy