-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Podspec #866
Update Podspec #866
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,8 +14,6 @@ Pod::Spec.new do |spec| | |
spec.ios.weak_frameworks = 'AssetsLibrary' | ||
spec.weak_frameworks = 'Photos','MapKit' | ||
|
||
spec.requires_arc = true | ||
|
||
spec.ios.deployment_target = '9.0' | ||
spec.tvos.deployment_target = '9.0' | ||
|
||
|
@@ -41,7 +39,6 @@ Pod::Spec.new do |spec| | |
# See https://github.com/facebook/AsyncDisplayKit/issues/1153 | ||
'Source/TextKit/*.h', | ||
] | ||
core.xcconfig = { 'GCC_PRECOMPILE_PREFIX_HEADER' => 'YES' } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We no longer use a prefix header. |
||
end | ||
|
||
spec.subspec 'PINRemoteImage' do |pin| | ||
|
@@ -65,10 +62,4 @@ Pod::Spec.new do |spec| | |
spec.default_subspec = 'PINRemoteImage' | ||
|
||
spec.social_media_url = 'https://twitter.com/TextureiOS' | ||
spec.library = 'c++' | ||
spec.pod_target_xcconfig = { | ||
'CLANG_CXX_LANGUAGE_STANDARD' => 'c++11', | ||
'CLANG_CXX_LIBRARY' => 'libc++' | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (See PR description). These options have been here since the initial OSS release and aren't adding value anymore. The default clang C++ options under Xcode 9 (and probably Xcode 8) are sufficient. |
||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been the default since 2014.