Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Podspec #866

Merged
merged 3 commits into from
Apr 4, 2018
Merged

Update Podspec #866

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ff4e0d
Update the podspec
Apr 3, 2018
d4dfd1e
Put that back
Apr 3, 2018
607dfd7
Put back the C++ standard library
Apr 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions Texture.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ Pod::Spec.new do |spec|
spec.ios.weak_frameworks = 'AssetsLibrary'
spec.weak_frameworks = 'Photos','MapKit'

spec.requires_arc = true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been the default since 2014.

spec.ios.deployment_target = '9.0'
spec.tvos.deployment_target = '9.0'

Expand All @@ -41,7 +39,6 @@ Pod::Spec.new do |spec|
# See https://github.com/facebook/AsyncDisplayKit/issues/1153
'Source/TextKit/*.h',
]
core.xcconfig = { 'GCC_PRECOMPILE_PREFIX_HEADER' => 'YES' }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer use a prefix header.

end

spec.subspec 'PINRemoteImage' do |pin|
Expand All @@ -65,10 +62,4 @@ Pod::Spec.new do |spec|
spec.default_subspec = 'PINRemoteImage'

spec.social_media_url = 'https://twitter.com/TextureiOS'
spec.library = 'c++'
spec.pod_target_xcconfig = {
'CLANG_CXX_LANGUAGE_STANDARD' => 'c++11',
'CLANG_CXX_LIBRARY' => 'libc++'
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(See PR description). These options have been here since the initial OSS release and aren't adding value anymore. The default clang C++ options under Xcode 9 (and probably Xcode 8) are sufficient.

end