Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ASDISPLAYNODE_ASSERTIONS_ENABLED and ASDefaultPlaybackButton warnings #trivial #880

Merged
merged 2 commits into from
Apr 12, 2018
Merged

Fix ASDISPLAYNODE_ASSERTIONS_ENABLED and ASDefaultPlaybackButton warnings #trivial #880

merged 2 commits into from
Apr 12, 2018

Conversation

maicki
Copy link
Contributor

@maicki maicki commented Apr 11, 2018

Adlai-Holler
Adlai-Holler approved these changes Apr 12, 2018
View reviewed changes
Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so insane that defined() can't be used as a bool. Anyway 👍

@maicki maicki merged commit 0aefbb6 into master Apr 12, 2018
@rainypixels rainypixels mentioned this pull request Apr 18, 2018
Open
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
@maicki @bernieperez
Fix ASDISPLAYNODE_ASSERTIONS_ENABLED and ASDefaultPlaybackButton warn…
80f9a47 
…ings #trivial (TextureGroup#880)

* Define ASDISPLAYNODE_ASSERTIONS_ENABLED explicitly

* Add parameter type for drawRect: in ASDefaultPlaybackButton
@Adlai-Holler Adlai-Holler deleted the MSFixXcode93Warnings branch June 14, 2018 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adlai-Holler Adlai-Holler Adlai-Holler approved these changes

@garrettmoon garrettmoon Awaiting requested review from garrettmoon

@nguyenhuy nguyenhuy Awaiting requested review from nguyenhuy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maicki @Adlai-Holler