[ASTextNode] Check variables before calling delegate method #trivial #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
av0c0der
changed the title
Generated by 🚫 Danger |
av0c0der
changed the title
maicki
approved these changes
Apr 30, 2018
There was a problem hiding this comment.
@jauzee Thanks for fixing!
I just looked into that and the problem is that we don't declare longPressedLinkAttribute: and the value: parameters as nullable. In this case it will crash on Swift's side as we will pass in a null if we don't check that the long press happened on a link.
The fix seems reasonable for me as we first check if there actually a long press happened on a link.
nguyenhuy
approved these changes
May 11, 2018
|
LGTM. Thanks, @jauzee! |
|
@maicki @nguyenhuy it's a pleasure for me to make this little contribution to the great tool which helping me a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug in ASTextNode. If you do a long tap outside of the text area it'll crash.
I'm not sure about the fix, but I added a check for
[self _pendingLinkTap]as fortappedLinkAttributemethod and now it works correctly.Reproduce
To reproduce a bug, please open demo project and do a long press on the right side of the text node.