Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent UITextView from updating contentOffset while deallocating #915

Merged
merged 2 commits into from
May 9, 2018
Merged

Prevent UITextView from updating contentOffset while deallocating #915

merged 2 commits into from
May 9, 2018

Conversation

maicki
Copy link
Contributor

@maicki maicki commented May 8, 2018

Adresses: #860

@maicki maicki requested a review from Adlai-Holler May 8, 2018 20:29
Adlai-Holler
Adlai-Holler approved these changes May 8, 2018
View reviewed changes
Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding a comment on the flag pointing to the issue but 👍

@maicki maicki merged commit efe924c into master May 9, 2018
@nguyenhuy nguyenhuy mentioned this pull request May 21, 2018
Closed
@maicki maicki deleted the MSFixTextViewDealloc branch July 29, 2018 15:34
@Shaninnik Shaninnik mentioned this pull request Aug 2, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adlai-Holler Adlai-Holler Adlai-Holler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maicki @Adlai-Holler