Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up async transaction system a bit #955

Merged
merged 2 commits into from
Jun 2, 2018
Merged

Clean up async transaction system a bit #955

merged 2 commits into from
Jun 2, 2018

Conversation

Adlai-Holler
Copy link
Member

  • Remove unused methods.
    • addAsyncOperation we no longer do async rendering.
    • addCompletion this was implemented in a somewhat questionable way anyway.
    • addOperation without priority. You can just specify default priority.
  • Implement CALayer category properties using CALayer dynamic properties rather than associated objects.
  • Tighten up the mainTransactionGroup API and trivial reorg of its implementation.

maicki
maicki approved these changes Jun 2, 2018
View reviewed changes
Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Adlai-Holler Adlai-Holler merged commit 21973c8 into master Jun 2, 2018
@Adlai-Holler Adlai-Holler deleted the AHCleanupTransactions branch June 2, 2018 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maicki maicki maicki approved these changes

@garrettmoon garrettmoon Awaiting requested review from garrettmoon

@appleguy appleguy Awaiting requested review from appleguy

@nguyenhuy nguyenhuy Awaiting requested review from nguyenhuy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Adlai-Holler @maicki