Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when call needsMainThreadDeallocation on NSProxy instances #trivial #965

Merged
merged 2 commits into from
Jun 12, 2018
Merged

Fix crash when call needsMainThreadDeallocation on NSProxy instances #trivial #965

merged 2 commits into from
Jun 12, 2018

Conversation

nguyenhuy
Copy link
Member

@nguyenhuy nguyenhuy commented Jun 12, 2018 •
edited
Loading

screen shot 2018-06-12 at 5 39 51 pm

Adlai-Holler
Adlai-Holler approved these changes Jun 12, 2018
View reviewed changes
Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the coverage here @nguyenhuy!

maicki
maicki approved these changes Jun 12, 2018
View reviewed changes
Copy link
Contributor

@maicki maicki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great investigation!

@nguyenhuy nguyenhuy merged commit 42ac10a into TextureGroup:master Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maicki maicki maicki approved these changes

@Adlai-Holler Adlai-Holler Adlai-Holler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nguyenhuy @maicki @Adlai-Holler