Remove unused/unneeded header macros #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
approved these changes
Jun 18, 2018
| @@ -160,7 +160,7 @@ namespace ASDN { | |||
| public: | |||
| #if !TIME_LOCKER | |||
|
|
|||
| Locker (T &l) ASDISPLAYNODE_NOTHROW : _l (l) { | |||
| Locker (T &l) noexcept : _l (l) { | |||
There was a problem hiding this comment.
I'm not pretty sure if we compile Texture with C++14 at the moment as you mention in the description, that said I think it was introduced in C++11 though. Can you double check when it was introduced and if 14 what we are building with please. Thanks!
There was a problem hiding this comment.
Yep this is from c++11 but glad I double-checked.
| for (int i=0; i< ARRAY_COUNT(UIContentModeDescriptionLUT); i++) { | ||
| if (UIContentModeDescriptionLUT[i].contentMode == contentMode) { | ||
| return UIContentModeDescriptionLUT[i].string; | ||
| for (auto &e : UIContentModeDescriptionLUT) { |
There was a problem hiding this comment.
Maybe a better variable name as e in this cases ;)
There was a problem hiding this comment.
I think e is short for entry and maybe there's a better name out there but I don't really want to wait for CI to rebuild.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AS_ARRAY_COUNTis replaced by C++ array iteration.hidden/pure/constaren't used.ASDISPLAYNODE_WARN_UNUSEDis unused in favor ofAS_WARN_UNUSED_RESULTASDISPLAYNODE_NOT_DESIGNATED_INITIALIZERis unnecessary since we can mark the initializer unavailable.ASDISPLAYNODE_NOTHROWis superseded by thenoexceptdecorator from C++11 ( https://en.cppreference.com/w/cpp/language/noexcept_spec )