Remove yoga layout spec, which has been superseded #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 29, 2018 18:23
…splay node integration
Adlai-Holler
force-pushed
the
AHRemoveYogaSpec
branch
from
3da6cf5
to
66d6506
Compare
maicki
approved these changes
Jun 30, 2018
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Oct 2, 2018
* Remove yoga layout spec, which has been superseded by tighter yoga-display node integration * Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yoga does not expose enough internal state during layout passes to use
YogaMeasureFuncfor containers – it can only be used for leaves. So there's a conceptual mismatch there.The yoga integration has been superseded by
insertYogaChild:and friends, inside ASDisplayNode+Beta.h.