Make the container configurable via env variable; update documentation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ended up making quite a few more changes, including dropping the separate copy of mdns-repeater.c entirely in favor of basing the image directly on containers shipped by monstrenyatko/docker-mdns-repeater, and creating some Dockerhub images of our own. Please let me know what you think the best way to reconcile this would be. I'm open to merging this back wholesale, or spinning this fork out. Last but not least, thanks for your work, and I'm looking forward to your pcapless repeater :)) |
|
Thanks for PR! I will look at it by the end of the week |
falzm
reviewed
Apr 10, 2023
README.md
Outdated
| @@ -1,82 +1,69 @@ | |||
| # docker-mdns-repeater-mikrotik | |||
| mdns-repeater in mikrotik container | |||
| An mDNS repeater that can ran as a container on Mikrotik routers. | |||
There was a problem hiding this comment.
Suggested change
| An mDNS repeater that can ran as a container on Mikrotik routers. | |
| An mDNS repeater that can run as a container on Mikrotik routers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some changes to allow the container to be configured without rebuilding -- this might eventually allow an image to get published to a registry.
Also expanded the documentation by attempting to explain how this container works.