Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash Koin compose 1.1.2 in Sample todo #224

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Fix crash Koin compose 1.1.2 in Sample todo #224

merged 2 commits into from
Dec 26, 2023

Conversation

hoangchungk53qx1
Copy link
Contributor

@hoangchungk53qx1 hoangchungk53qx1 commented Dec 25, 2023 •
edited
Loading

Issue : #222

@hoangchungk53qx1 hoangchungk53qx1 changed the title Fix crash Koin compose 1.1.2 Fix crash Koin compose 1.1.2 in Sample todo Dec 25, 2023
Tlaster
Tlaster reviewed Dec 26, 2023
View reviewed changes
Copy link
Owner

@Tlaster Tlaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

sample/todo/common/src/commonMain/kotlin/moe/tlaster/common/App.kt Outdated Show resolved Hide resolved
Tlaster
Tlaster approved these changes Dec 26, 2023
View reviewed changes
Copy link
Owner

@Tlaster Tlaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@Tlaster Tlaster linked an issue Dec 26, 2023 that may be closed by this pull request
Sample ToDo app crashes with KoinCompose 1.1.2 #222
Closed
@Tlaster Tlaster merged commit ac3428a into Tlaster:master Dec 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tlaster Tlaster Tlaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sample ToDo app crashes with KoinCompose 1.1.2
2 participants
@hoangchungk53qx1 @Tlaster