Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confusing API from goBack #270

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

tiper
Copy link
Contributor

@tiper tiper commented Feb 14, 2024

Having PopUpTo as a parameter in the goBack function with an inclusive flag adds complexity.

Providing multiple values for this operation can lead to confusion.

Copy link
Owner

@Tlaster Tlaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opps I didn't notice that.
Thanks for the PR!

@Tlaster Tlaster merged commit 42eaf85 into Tlaster:master Feb 14, 2024
2 checks passed
@tiper tiper deleted the bugfix/goBack branch March 4, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants