Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove appcompat dependency #316

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

martinbonnin
Copy link
Contributor

Looks like appcompat is not needed?

More context in paug/AndroidMakersApp#299

@Tlaster
Copy link
Owner

Tlaster commented Apr 27, 2024

Seems like we also need to update the sample code as well in order to pass the ci build.

@martinbonnin
Copy link
Contributor Author

Seems like we also need to update the sample code as well in order to pass the ci build.
I just pushed ec704b5

@cbeyls
Copy link

cbeyls commented Apr 27, 2024

Actually the sample doesn't need AppCompat either.
MainActivity doesn't extend AppCompatActivity so it shouldn't use an AppCompat theme in the Manifest. The theme should be changed to a system theme instead.

@martinbonnin
Copy link
Contributor Author

Actually the sample doesn't need AppCompat either.
MainActivity doesn't extend AppCompatActivity so it shouldn't use an AppCompat theme in the Manifest. The theme should be changed to a system theme instead.

Sounds good to me. I'll let the maintainers decide how they want to handle this. I have enabled maintainers edit. Feel free to push to this branch and/or create a follow up PR

@Tlaster
Copy link
Owner

Tlaster commented Apr 28, 2024

Actually the sample doesn't need AppCompat either.
MainActivity doesn't extend AppCompatActivity so it shouldn't use an AppCompat theme in the Manifest. The theme should be changed to a system theme instead.

Sounds good to me. I'll let the maintainers decide how they want to handle this. I have enabled maintainers edit. Feel free to push to this branch and/or create a follow up PR

The sample code is just a prototype. If it builds successfully, everything should be fine. Additionally, I plan to update the sample to align with JetBrains' Compose Multiplatform template and keep the project current.

@Tlaster Tlaster merged commit cc39364 into Tlaster:master Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants