Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve installation instructions #212

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

svencan
Copy link
Contributor

@svencan svencan commented Sep 22, 2023

This adds the link to the releases in the installation sections, as people who skip the "run the demo" part tend to download the main branch instead of a release.

@TokisanGames
Copy link
Owner

Great, thanks. Please add this to the first line , or [build the plugin from source](https://github.com/TokisanGames/Terrain3D/wiki/Building-From-Source).

Generally I'm not so concerned about squashing, but if you were submitting to Godot they are religious about it. It will be good practice to learn and for fixing a change like this. Make the above change and commit. Then look at the PR workflow document to do an interactive rebase git rebase -i HEAD~3, change the first word of the second and third commits to fixup so it merges them all into one, then do a force push to overwrite the server branch.

@svencan
Copy link
Contributor Author

svencan commented Sep 22, 2023

Changed as requested and squashed the commits. Thanks for the hint!

@TokisanGames
Copy link
Owner

Great, thanks!

@TokisanGames TokisanGames merged commit ca11fe3 into TokisanGames:main Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants