Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger: Add command line switch --terain3d-debug #247

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

lw64
Copy link
Contributor

@lw64 lw64 commented Nov 13, 2023

Fixes #230

Copy link
Owner

@TokisanGames TokisanGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good.

  • Please format it with braces and indents like this:
if (value == "MESG") {
    set_debug_level(MESG);
} else if (value == "ERROR") {
     set_debug_level(ERROR);
}
  • You can remove MESG.
  • Remove space after begins_with
  • Install clang-format and install the hooks onto your system. That will help with automatic formatting whenever you commit.

https://github.com/TokisanGames/Terrain3D/blob/main/CONTRIBUTING.md#clang-format

@TokisanGames
Copy link
Owner

Did you commit and push your changes to this? It looks exactly the same. I don't see that any of the points above were addressed.

@TokisanGames
Copy link
Owner

Very good, thank you.

@TokisanGames TokisanGames merged commit 3f79ad2 into TokisanGames:main Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable debugging on the command line
2 participants